docs(plans): reconcile Go JSON delivery with merged implementation by coderdan · Pull Request #1353 · cipherstash/stack

coderdan · 2026-10-24T01:16:35Z

Go JSON is now implemented on next. This documentation-only PR records the supported contract and the remaining customer delivery work, reconciled against next at ffeed7a (2026-10-27).

The plan stays at docs/plans/2026-10-24-go-json-tree.md, preserving tracking links. Its companion engine findings and new Go implementation-status document cite the reviewed source. Tracking #1347 and implementation issues #1348–#1352 are now closed.

What changed in the plan

Mark configured targets, strict JSON ingress, dynamic operators, request-bound reads, generated typed Go documents and executable examples as implemented (feat(stack-encrypt,eql): store a JSON document through a data plan as JsonSearch #1372, feat(stack-encrypt, golang): JSON operators and data-plan reads, with generated Go JSON document fields (#1374) #1373, feat(go): encrypted JSON documents of Go types, with typed needles #1378, docs(go): typed JSON walkthrough and accurate EQL reference #1402).
Use actual names: JsonSearch, eql.JSONSearch, JSONSearchQuery, JSONSearchLeafQuery and JSONEntry, with the current SQL domains. Prepared reads open with Open(ctx, rows).
Account for feat(stack-encrypt): cascade the JSON tree's AEAD tags and store its entries in a random order #1379's cascade authentication and randomized storage/projection order. Wildcard -> selects an unspecified element; use explicit all-match semantics. Freeze post-cascade vectors despite the unchanged header version.
Mark Go opaque storage adoption complete (chore(deps): take vitaminc's Go bindings from cipherstash/vitaminc#526 by git reference #1369/feat(go): seal an opaque struct as a vitaminc storage blob #1370). Final Go releases still require replacing temporary Vitamin C pseudo-version pins; prereleases may carry them.
Record feat(stack-encrypt): make two-letter words such as "Ng" searchable in the match index #1397's implemented short-word terms separately from unfinished configurable Go match options and the earlier privacy concern.

Remaining delivery work

Formalize the implemented dynamic contract and conformance corpus; complete parent-bound child opening; address required complex ordered-path declarations and configurable Go match options (#1112); validate the assembled release and freeze storage/search profiles. Direct typed EQL conversion and broader Rust/context/packaging work remain explicit follow-ups.

SQL children/count preparation does not implement a plaintext child opener. Selector opening accepts one entry per document group; bounded subtree reads provide the supported all-match plaintext route. Keep these limits visible rather than treating closed issues as proof that every proposed convenience exists.

Validation

Reviewed nine first-parent merges since ebdb5de, source, existing tests, documentation and issue states. Checked Markdown fences, JSON examples, relative links and git diff whitespace. Runtime and database suites were not rerun. No production code changes relative to next.

Related: #1365 for the broader API design. Ngram research and the separate Go delivery document remain outside this PR.

Plans how a Go program declares, stores and queries an encrypted JSON document (EQL v4 json_tree). Most of the work is in Rust: the engine refuses the JSON index in a data plan, and the family is missing from the EQL catalog, so Go has no types to generate. Five steps, one issue each, with the decisions the Go surface needs. Refs #1347 Claude-Session: https://claude.ai/code/session_01XQN1QpaWVDGjHEg39KEJF3

changeset-bot · 2026-10-24T01:16:41Z

⚠️ No Changeset found

Latest commit: fb4b9e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-10-24T01:16:43Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI; Enforced overrides: Organization
Review profile: CHILL
Plan: Advanced
Run ID: 29564849-be02-4f12-be83-d32acec62e2d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

Trigger review

CodeRabbit Verify

Run CodeRabbit Verify to test the changes in this pull request.

chatgpt-codex-connector · 2026-11-03T11:49:08Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-03T11:50:19.855929Z	`fb4b9e7`	Draft marked ready
🔒 Security Review	✅ Completed 2026-11-03T11:50:37.446194Z	`fb4b9e7`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

cipherstash-agent

Review attestation

Reviewed fb4b9e7 · posted from Claude Code · model unknown (runtime-selected) · effort medium
Sources: code-review (medium) · model unknown
Skills: code-review, review-cross-check, review-post

Findings (4): 4 minor — 4 inline.

One further candidate was dropped: the EQL v4 section cites packages/eql/src/v3/json_tree/functions.sql. That is the only json_tree SQL in the tree, so it is likely the shared implementation. Worth a one-line note in the doc if so.

Generated by Claude Code

cipherstash-agent · 2026-11-03T11:50:52Z

+   and shared conformance corpus; allocate versioning explicitly. Do not
+   describe the earlier illustrative versioned envelope as already accepted
+   by the runtime. General definition caches and Rust factories can follow.
+2. **Close narrow coverage gaps.** Add parent-bound child-scalar opening


minor Item 2 commits to adding parent-bound child-scalar opening, but the table (line 144), the engine doc (line 120) and the status doc (line 105) treat it as an open decision. Reword to "decide whether to add".

_{Source: code-review (medium) · runtime-selected model}

Generated by Claude Code

cipherstash-agent · 2026-11-03T11:50:52Z

+   (#1112); configurable tokenizers/filter pipelines are not thereby done.
+   The implementation uses deterministic domain-separated word terms, not
+   random variants. This review records that fact without settling the
+   previously raised privacy concern or changing the uncommitted research.


minor "The previously raised privacy concern" and "the uncommitted research" have no link or description, so the open question cannot be acted on. Link the issue or document, or state the concern in one sentence.

_{Source: code-review (medium) · runtime-selected model}

Generated by Claude Code

cipherstash-agent · 2026-11-03T11:50:52Z

+
+This refresh inspected the nine first-parent merges, current source,
+changelogs, tests and documentation, and checked the tracking issue states.
+No new runtime code was written. Markdown/link/JSON checks are run on the


minor "Markdown/link/JSON checks are run on the plan changes" is not backed by anything in the PR, and the status doc says no fresh run was made. Run the checks and say how, or drop the claim.

_{Source: code-review (medium) · runtime-selected model}

Generated by Claude Code

cipherstash-agent · 2026-11-03T11:50:52Z

+round-trip empty, nonfinite floats are allowed, and some formerly JSON-only
+opaque types are refused. No new migration system is requested here.
+
+Go currently pins Vitamin C at `06568ba93bd9` using pseudo-versions. Rust


minor The pins (Vitamin C 06568ba93bd9, Rust 0.8.0) are written as current facts and will mislead once they move. Anchor them "as of ffeed7ad". The filename date (10-24) also disagrees with Updated: 2026-10-27.

_{Source: code-review (medium) · runtime-selected model}

Generated by Claude Code

coderdan mentioned this pull request Oct 24, 2026

Tracking: encrypted JSON documents (json_tree) in the Go SDK #1347

Closed

Base automatically changed from feat/json-tree-gates to next October 24, 2026 06:12

coderdan mentioned this pull request Oct 25, 2026

docs: define Stack Encrypt API redesign plan #1365

Open

docs: revise Go JSON dynamic contract plan

42c38f4

coderdan changed the title ~~docs(plans): the json_tree capability in the Go SDK~~ docs(plans): define Go JSON dynamic contract and delivery Oct 25, 2026

coderdan added 2 commits October 27, 2026 13:02

Merge remote-tracking branch 'origin/next' into HEAD

219d0e0

docs: reconcile Go JSON plan with implementation

fb4b9e7

coderdan changed the title ~~docs(plans): define Go JSON dynamic contract and delivery~~ docs(plans): reconcile Go JSON delivery with merged implementation Oct 27, 2026

coderdan marked this pull request as ready for review November 3, 2026 11:48

coderdan requested a review from a team as a code owner November 3, 2026 11:48

cipherstash-agent reviewed Nov 3, 2026

View reviewed changes

Navigation Menu

Repository navigation

docs(plans): reconcile Go JSON delivery with merged implementation - #1353

docs(plans): reconcile Go JSON delivery with merged implementation#1353
coderdan wants to merge 4 commits into
nextfrom
docs/go-json-tree-plan

coderdan commented Oct 24, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 24, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 24, 2026 •

edited

Loading

Review skipped

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026 •

edited

Loading

Uh oh!

cipherstash-agent left a comment

Uh oh!

cipherstash-agent Nov 3, 2026

Uh oh!

cipherstash-agent Nov 3, 2026

Uh oh!

cipherstash-agent Nov 3, 2026

Uh oh!

cipherstash-agent Nov 3, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

coderdan commented Oct 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed in the plan

Remaining delivery work

Validation

Uh oh!

changeset-bot Bot commented Oct 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Oct 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

CodeRabbit Verify

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

cipherstash-agent left a comment

Choose a reason for hiding this comment

Review attestation

Uh oh!

cipherstash-agent Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

cipherstash-agent Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

cipherstash-agent Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

cipherstash-agent Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderdan commented Oct 24, 2026 •

edited

Loading

changeset-bot Bot commented Oct 24, 2026 •

edited

Loading

coderabbitai Bot commented Oct 24, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 3, 2026 •

edited

Loading